Emit owner/repo/commit tags for GraphQL queries#1254
Conversation
✅ Sentry found no issues in your recent changes ✅ |
| # TODO(swatinem): We should find a way to avoid these combinators: | ||
| # The `with_recent_coverage` combinator is quite expensive. | ||
| # We only need that in case we want to query these props via graphql: | ||
| # `coverageAnalytics.{percentCovered,commitSha,hits,misses,lines}` | ||
| # Similarly, `with_oldest_commit_at` is only needed for `oldestCommitAt`. |
There was a problem hiding this comment.
The query generated by the combinators below is this:
https://codecov.sentry.io/insights/backend/database/spans/span/fbbb13620d0da28b/?project=5215654&statsPeriod=30d
As you can see, it is incredibly complex, and also slow.
There was a problem hiding this comment.
note to self:
mirumee/ariadne#1116 (comment)
this snippet might help achieve that goal. but by god why that is not part of the standard graphql tooling is beyond me. this looks like fundamental functionality that should just exist out of the box.
This primarily adds Sentry tags to GraphQL endpoints that resolve any kind of field on `Repository.commit`, etc. This should make it a lot easier to search for traces related to a specific repo or commit.
Swatinem
force-pushed
the
swatinem/graphql-tags
branch
from
8d03f8d to
f5de483
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
+ Coverage 96.31% 96.33% +0.01%
==========================================
Files 492 492
Lines 16805 16896 +91
==========================================
+ Hits 16185 16276 +91
Misses 620 620
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
2 participants
This primarily adds Sentry tags to GraphQL endpoints that resolve any kind of field on
Repository.commit, etc. This should make it a lot easier to search for traces related to a specific repo or commit.